Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): improve watch solution, ignore _meta.json out of doc root dir #1312

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented Aug 8, 2024

Summary

before:

  1. rspress will watch all file in doc root dir, but only handle some config file.
  2. all the _meta.json in cwd are watched.

now

  1. only watch _meta.json files in doc root dir.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 939d203
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66b48e3fea8e0700080f985f
😎 Deploy Preview https://deploy-preview-1312--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zllkjc zllkjc changed the title fix(rspress): improve watch solution, ignore _meta.json out of doc root dir fix(watch): improve watch solution, ignore _meta.json out of doc root dir Aug 8, 2024
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@Timeless0911 Timeless0911 merged commit 51ba94a into main Aug 8, 2024
10 checks passed
@Timeless0911 Timeless0911 deleted the fix/watch-solution branch August 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants