-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): replace twitter with x in soicalLinks config #1316
Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/theme-default/src/components/SocialLinks/presetIcons.tsx
Outdated
Show resolved
Hide resolved
b2953a6
to
f44ae07
Compare
I think this is still a break change. We should give a clear heads up about it |
We may need to mention it in docs and terminal outputs since we remove the type of twitter |
Not a big breaking change, adding documentation and release note will be good enough.. |
I didn't remove it. Just added the |
Summary
Replacing
twitter
withX
, with new logo and config nameRelated Issue
SKIP
Checklist