Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): replace twitter with x in soicalLinks config #1316

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

zoolsher
Copy link
Contributor

@zoolsher zoolsher commented Aug 8, 2024

Summary

Replacing twitter with X, with new logo and config name

Related Issue

SKIP

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit f44ae07
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66b4cabdb6f423000750077f
😎 Deploy Preview https://deploy-preview-1316--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911
Timeless0911 previously approved these changes Aug 8, 2024
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Timeless0911 Timeless0911 enabled auto-merge (squash) August 8, 2024 13:18
@Timeless0911 Timeless0911 disabled auto-merge August 8, 2024 13:19
@Timeless0911 Timeless0911 enabled auto-merge (squash) August 8, 2024 13:45
@zoolsher
Copy link
Contributor Author

zoolsher commented Aug 8, 2024

I think this is still a break change. We should give a clear heads up about it

@Timeless0911 Timeless0911 merged commit 25d1324 into main Aug 8, 2024
7 checks passed
@Timeless0911 Timeless0911 deleted the feat/replace-twitter-with-x branch August 8, 2024 13:47
@Timeless0911
Copy link
Contributor

Timeless0911 commented Aug 8, 2024

We may need to mention it in docs and terminal outputs since we remove the type of twitter

@chenjiahan
Copy link
Member

Not a big breaking change, adding documentation and release note will be good enough..

@zoolsher
Copy link
Contributor Author

We may need to mention it in docs and terminal outputs since we remove the type of twitter

I didn't remove it. Just added the x to types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants