Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window unexpected href when feature link is not configured #1329

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

normalizeHrefInRuntime(withBase(rawLink, routePath)) will generate a /index, which will cause unexpected window href if user click a feature component without link configured.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 changed the title fix: window href when feature link is not configured fix: window unexpected href when feature link is not configured Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 77f3773
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66bc8a55ce1cd80008c12113
😎 Deploy Preview https://deploy-preview-1329--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 enabled auto-merge (squash) August 14, 2024 10:44
@Timeless0911 Timeless0911 merged commit d16b4b6 into main Aug 14, 2024
7 checks passed
@Timeless0911 Timeless0911 deleted the fix/feature-link branch August 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants