Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-auto-nav-sidebar): auto generated sidebar should consider route.extensions when _meta.json don't exists #1369

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix(plugin-auto-nav-sidebar): auto generated sidebar should consider route.extensions when _meta.json don't exists #1369

merged 1 commit into from
Aug 30, 2024

Conversation

shulaoda
Copy link
Contributor

Summary

closes #1327
closes #1349
closes #1365

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda
fix(plugin-auto-nav-sidebar): auto generated sidebar should consider …
20f8193 
…route.extensions when _meta.json don't exists
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 20f8193
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66d18975ab23f70008a150d9
😎 Deploy Preview https://deploy-preview-1369--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 82 (🔴 down 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911
Timeless0911 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timeless0911 Timeless0911 merged commit 19698a1 into web-infra-dev:main Aug 30, 2024
8 checks passed
@shulaoda shulaoda deleted the fix/plugin-auto-nav-sidebar-no-meta branch August 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
2 participants
@shulaoda @Timeless0911