Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove margin-left for single a tag in SocialLinks component #1391

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

huyixi
Copy link
Contributor

@huyixi huyixi commented Sep 5, 2024

This commit fixes an issue where a single tag in the SocialLinks component would have an unwanted margin-left, causing misalignment. The issue is resolved by using the :only-child pseudo-class to remove the margin-left when there is
only one tag.

Updated index.module.scss to include the necessary CSS selector.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 02478b3
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66d92939e45daa0008cb9602
😎 Deploy Preview https://deploy-preview-1391--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Contributor

Timeless0911 commented Sep 5, 2024

before

image

after

image

You can see the display. Your PR makes the left and right spacing not look well when there is only one social link.

image

The margins to the theme switch button are too small.

@huyixi
Copy link
Contributor Author

huyixi commented Sep 5, 2024

before

image

after

image

You can see the display. Your PR makes the left and right spacing not look well when there is only one social link.

image

The margins to the theme switch button are too small.

I forgot to consider the situation on large screens. The new PR has fixed this issue

before:
SCR-20240905-livn
after:
SCR-20240905-lhxy

@Timeless0911 Timeless0911 enabled auto-merge (squash) September 5, 2024 04:57
@Timeless0911 Timeless0911 merged commit c3ffca1 into web-infra-dev:main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants