Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-default): Capitalise the 'P' in 'Next page' #1497

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

flother
Copy link
Contributor

@flother flother commented Oct 17, 2024

Summary

In the previous/next page links at the bottom of docs pages, the text used to read "Previous Page" (title case) and "Next page" (sentence case). This changes the "Next Page" link to title case so that the two links match style.

Screenshot of the updated link text

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

That way it matches the capitalisation of "Previous Page".
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 2e63a48
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67115c82199ac40008f0e807
😎 Deploy Preview https://deploy-preview-1497--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 14 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Timeless0911 Timeless0911 enabled auto-merge (squash) October 18, 2024 01:22
@Timeless0911 Timeless0911 disabled auto-merge October 18, 2024 01:28
@Timeless0911 Timeless0911 merged commit e3a2a18 into web-infra-dev:main Oct 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants