fix: correctly iterate over plugins when using removePlugin
#1507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling modifyConfig, if some plugins call
removePlugin
oraddPlugin
, the index of the plugin inthis.#plugins
will change. SinceaddPlugin
usespush
, it will not affect the index of other plugins. If it isremovePlugin
, it is necessary to consider whether the plugin to be removed is before the current traversal index. If so, the plugins after the index will move forward 1 inthis.#plugins
. If not, there will be no impact.Related Issue
Closes #1487
Checklist