fix: langRoutePrefix should end with slash

[JounQin]

Summary

langRoutePrefix is used at

rspress/packages/theme-default/src/components/Nav/NavBarTitle.tsx

Line 47 in ae1bf88

href={localeData.langRoutePrefix}

Without the trailing slash, for located pages, it renders /zh for example, which means /zh.html but it should be /zh/index.html actually. And this change matches the default langRoutePrefix (/).

Related Issue

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name	Link
🔨 Latest commit	5f94ea0
🔍 Latest deploy log	https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6721d7ef1e6110000816cef7
😎 Deploy Preview	https://deploy-preview-1539--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🟢 up 11 from production) Accessibility: 97 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Timeless0911]

I think we should only modify code here

rspress/packages/theme-default/src/components/Nav/NavBarTitle.tsx

Line 47 in ae1bf88

href={localeData.langRoutePrefix}

instead of the public hook of useLocaleSiteData which may brings breaking changes.

[JounQin]

@Timeless0911 The default langRoutePrefix is /, so I believe langRoutePrefix should always end with slash?

[Timeless0911]

The default langRoutePrefix is /, so I believe langRoutePrefix should always end with slash?

I cannot confirm whether the modification of this hook will affect the use in other places and other users who import it at runtime. In addition, personally I think langRoutePrefix should be '' and zh, just like what sidebar component do in

rspress/packages/theme-default/src/components/Sidebar/index.tsx

Line 93 in ae1bf88

const langRoutePrefix = normalizeSlash(localesData.langRoutePrefix || '');

This should be optimized with normalizeHref function together in the future, rspress.dev/index rspress.dev/zh/index is ugly than rspress.dev rspress.dev/zh

rspress/packages/shared/src/runtime-utils/index.ts

Lines 235 to 263 in ae1bf88

	export function normalizeHref(url?: string, cleanUrls = false) {
	if (!url) {
	return '/';
	}
	if (isExternalUrl(url)) {
	return url;
	}
	// eslint-disable-next-line prefer-const
	let { url: cleanUrl, hash } = parseUrl(decodeURIComponent(url));
	if (!cleanUrls && !cleanUrl.endsWith('.html')) {
	if (cleanUrl.endsWith('/')) {
	cleanUrl += 'index.html';
	} else {
	cleanUrl += '.html';
	}
	}
	if (cleanUrls && cleanUrl.endsWith('/')) {
	cleanUrl += 'index';
	}
	if (cleanUrls && cleanUrl.endsWith('.html')) {
	cleanUrl = cleanUrl.replace(/\.html$/, '');
	}
	return addLeadingSlash(hash ? `${cleanUrl}#${hash}` : cleanUrl);
	}

[JounQin]

In addition, personally I think langRoutePrefix should be '' and zh, just like what sidebar component do in

There is a problem that /zh/ (/zh/index.html) and /zh (/zh.html) are totally different.

When toggling language, it goes to /zh/index in https://github.com/web-infra-dev/rspress/blob/main/packages/theme-default/src/components/Nav/NavVersions.tsx.

[Timeless0911]

This should be an issue related to the href link issue of home page in different languages.

Current

• navbarTitle zh
  

• navbarTitle en
  

• translation menu zh
  

• translation menu en
  

Expected

• rspress.dev in en (default lang)
• rspress.dev/zh in zh

[Timeless0911]

There is a problem that /zh/ (/zh/index.html) and /zh (/zh.html) are totally different.

Yes, this is a question that needs to be considered. The situation is different when there is an html suffix or not (cleanUrls enabled or not).

[JounQin]

rspress.dev/zh in zh

Is this really expected? As I mentioned, /zh means /zh.html which SSG does not generates at all, rspress.dev/zh/ is fine for /zh/index.html.

[Timeless0911]

Is this really expected? As I mentioned, /zh means /zh.html which SSG does not generates at all, rspress.dev/zh/ is fine for /zh/index.html.

I know what you mean, we should ensure the request is https://rspress.dev/zh/.

[Timeless0911]

In other words, your changes are no problem for resource requests, but the href display will appear a bit bloated. My goal is to simplify the content after the mouse hovers over it.

zh/ or zh with zh/ request is both ok.

[Timeless0911]

I think this PR can be merged for better semantics of link.