Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render inline markdown with generic syntax #1557

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Timeless0911
Copy link
Contributor

Summary

closes: #1536

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit c7d9dba
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/672b1efd45bd490008c35015
😎 Deploy Preview https://deploy-preview-1557--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Member

SoonIter commented Nov 6, 2024

😄 we should unify the sidebar, title, TOC, render logic

@Timeless0911
Copy link
Contributor Author

If we use dangerouslySetInnerHTML, it forces users to write HTML entities &lt; instead of \< which is more common in mdx writing. And the sidebar / markdown headings in cotent / TOC render logic should be unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Title with "\<" (escaped brackets) will crush the API overview
2 participants