Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-auto-nav-sidebar)!: when no _meta.json, index.md should be used as dir link #1575

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Nov 14, 2024

Summary

  1. THIS is a breaking change, treat index as dir link in default
  • when no _meta.json, treat index as dir link (breaking change)
  • no index in _meta.json, treat index as dir link
  • index in _meta.json, treat index as child sidebar as before

if you want to fallback to old behavior, please add a _meta.json and add the index file to it, then, index page would be placed to child sidebar

// _meta.json
["index", "guide"]
  1. by the way, refactor the Overview comp to pass the CI, and It will be compatible with this situation and more regular.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit f6db791
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6736d1511497ca000808cf73
😎 Deploy Preview https://deploy-preview-1575--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title chore(plugin-auto-nav-sidebar)!: when no _meta.json, index.md should be used as dir link feat(plugin-auto-nav-sidebar)!: when no _meta.json, index.md should be used as dir link Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants