Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom doc-layout components #1611

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

ap0nia
Copy link
Contributor

@ap0nia ap0nia commented Nov 20, 2024

Summary

The DocLayout uses internal components to render MDX nodes. There is no documented way (as far as I can tell) to override these nodes without providing an entirely custom DocLayout component altogether.

To address this, allow the user to provide components to the Layout component. In the future, maybe the DocLayout could be extended to handle arbitrary nodes as well.

Related Issue

Related to #1362 because this feature will allow the user to override and customize known MDX nodes.

Checklist

  • [ ] Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 553f5e3
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/673d9656d96c2b00084d70d1
😎 Deploy Preview https://deploy-preview-1611--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 enabled auto-merge (squash) November 20, 2024 08:02
@Timeless0911 Timeless0911 merged commit 3460c70 into web-infra-dev:main Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants