Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-preview): dev-server is not running #1648

Merged

Conversation

orionlize
Copy link
Contributor

Summary

Fix plugin-preview dev-server close, but not assign empty, next afterBuild close error.
image

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 547d6bf
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6756c0891662760008bafbb9
😎 Deploy Preview https://deploy-preview-1648--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 requested a review from SoonIter December 9, 2024 10:16
@Timeless0911
Copy link
Contributor

How to reproduce this error in your screenshot?

@orionlize
Copy link
Contributor Author

2024-12-11.10-05-36.mp4

@Timeless0911
Copy link
Contributor

2024-12-11.10-05-36.mp4

Can you upload this repo to Github?

@orionlize
Copy link
Contributor Author

2024-12-11.10-05-36.mp4

Can you upload this repo to Github?

https://github.com/orionlize/rspress-plugin-preview-bug

@Timeless0911 Timeless0911 merged commit c3cf124 into web-infra-dev:main Dec 11, 2024
8 checks passed
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants