Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close hamburger menu when click on item on mobile #1712

Merged

Conversation

coratgerl
Copy link
Contributor

Summary

When we click on an item in an hamburger menu, we should close the menu after click event.

Related Issue

Fixes: #1711

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 7107524
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/676d09fa44e2bf0008d938a8
😎 Deploy Preview https://deploy-preview-1712--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter
Copy link
Member

LGTM after adopting the suggestions

@coratgerl
Copy link
Contributor Author

Done ! Thanks for your feedbacks !

@Timeless0911 Timeless0911 merged commit 1b97444 into web-infra-dev:main Dec 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar doesn't close hamburger menu when click on item in mobile
3 participants