Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: private import not work in production #637

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

sanyuan0704
Copy link
Contributor

Summary

When we use #theme/logic to redirect to the module in @rspress/theme-default/src/logic, we cannot resolve the path because the src modules missed in production.

img_v3_0287_059adf62-3073-44b6-889d-a8f890476dcg

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 8a04682
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65d2c80fc1b4d00008a5e69e
😎 Deploy Preview https://deploy-preview-637--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 enabled auto-merge (squash) February 19, 2024 03:29
@sanyuan0704 sanyuan0704 disabled auto-merge February 19, 2024 03:47
@sanyuan0704 sanyuan0704 merged commit 2e1550a into main Feb 19, 2024
7 of 8 checks passed
@sanyuan0704 sanyuan0704 deleted the fix/theme-default-alias branch February 19, 2024 03:47
@sanyuan0704 sanyuan0704 mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants