Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PluginDriver): nav and sidebar add ? #751

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

wChenonly
Copy link
Contributor

Summary

image

If you configure locales in theme Config, it will report an error.
And the types nav and sidebar are optional.
image

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 2ed9bae
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65efe7327b989f0008d428de
😎 Deploy Preview https://deploy-preview-751--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🔴 down 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 merged commit 7bf8e1c into web-infra-dev:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants