Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): homepage mask based on logo vertical centering #917

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

seeintea
Copy link
Contributor

@seeintea seeintea commented Apr 7, 2024

Summary

Make the homepage mask vertically centered based on the logo.
Now the height of the mask is fixed, I'm not sure if this needs to be changed or not.

Related Issue

#897 [Bug]: The position of the homepage mask is offset from the logo

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 12a10ed
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/661232b837a3a00008aa40b3
😎 Deploy Preview https://deploy-preview-917--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 merged commit 63107df into web-infra-dev:main Apr 7, 2024
8 checks passed
@seeintea seeintea deleted the document-update branch October 22, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants