Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import statement from CSS modules feature #1165

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jun 3, 2024

Fixes #1164.

@foolip foolip requested a review from captainbrosset June 3, 2024 09:06
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jun 3, 2024
@captainbrosset
Copy link
Contributor

As posted here #1164 (comment), ensuring that we use BCD keys just once in the repo feels like an arbitrary limitation that will become a problem for us at some point.

Not opposed to making this quick change to fix MDN, and javascript.statements.import.import_attributes.type_css does mean that javascript.statements.import is supported anyway, so I will approve. But I wish we had a long term solution in place that didn't involve making BCD keys unique throughout the repo.

@foolip
Copy link
Collaborator Author

foolip commented Jun 3, 2024

@captainbrosset I've filed #1173 and will go ahead and link that with a TODO here instead.

@foolip foolip enabled auto-merge (squash) June 3, 2024 11:43
@foolip foolip merged commit 86b4857 into web-platform-dx:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline "limited availability" for ESM?
2 participants