-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename schema file to data.schema.json and publish it #1348
Conversation
The idea is that this would help with #715. We can publish web-features.schema.json in both the NPM package and the GitHub release. The name of the data files are different (index.json vs. data.json) so matching either of those names would still leave a mismatch in the other place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so the end-goal here is to export this on the package? import { schema } from "web-features"
? In any case, this is fine.
This is for @jcscottiii who is using GitHub releases for webstatus.dev, so the goal is to add a file alongside data.json in the GitHub releases. A change in the schema would be a strong clue that something needs updating. |
I've sent #1470, and if we do that I think we should call this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to update packages/web-features/README.md
with an example import
statement for this, but I won't block on it. One minor suggestion in a line comment.
This will include the schema in the NPM package. The idea is to also publish it with GitHub releases. Co-authored-by: Daniel D. Beck <[email protected]>
I've documented the import as |
This will include the schema in the NPM package. The idea is to also
publish it with GitHub releases.