Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple specification URLs #147

Merged
merged 3 commits into from
May 5, 2023
Merged

Allow multiple specification URLs #147

merged 3 commits into from
May 5, 2023

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 24, 2023

No description provided.

@foolip foolip requested a review from ddbeck April 24, 2023 14:16
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good my change in #44 has really confused matters.

You'll need something along the lines of this in index.ts

/** Web platform feature */
export interface FeatureData {
    /** Specification URLs */
    spec: spec_url | [spec_url, spec_url, ...spec_url[]];

and a corresponding spec_url type to make it such that npm run generate-schema-defs creates the desired output.

This suggests a follow-up task for me: write some test that fails if regenerating the schema creates a diff.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip I pushed some changes. If you're happy with this, then I am.

Copy link
Collaborator Author

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddbeck, looks good!

@foolip foolip merged commit 2013ccd into main May 5, 2023
@foolip foolip deleted the specs branch May 5, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants