-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature for CSS Typed OM #1847
Conversation
I'd propose a different approach- many of these keys should be part of separate features. For instance, This feature should contain the keys that are related to CSS syntax and wouldn't be part of other features. Some examples-
Some of the keys here can be added to existing features, but there are others like |
I'm taking another look at this, and would appreciate input from others. The Typed OM is not supported by Firefox yet, so if the Typed OM keys go with their corresponding properties, we will need to compute the status on each to ignore the typed OM keys. Alternatively, we can have a Typed OM feature as proposed here, that tells a clearer support story, but separates Any thoughts on where these keys should go? |
This is the core thing. I think a lot of the keys here could survive as a typed OM feature no matter what. The feature-specific keys, those are the troublesome ones. I'm going to make a pragmatic suggestion: put the per-feature keys into a draft feature—call it the typed OM "junk drawer" if we must. Sort the keys by which "real" feature they ought to live with and comment the lines accordingly. I think this is going to be one of the prime features for resolving #971. We'll need some way to declare inferior or interior or adjacent features and this seems like a likely candidate for taking it on, since we'll get a bunch of them at once. If we can deal with that soon, then great. If we get impatient, then we'll have done the work to decide where they'll need to be moved already. |
Another option would be to pull out a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some adjustments needed on the description, but otherwise I think this is good to go now.
Co-authored-by: Daniel D. Beck <[email protected]>
@queengooborg I shepherded this over the finish line since I had made some parallel changes in the interim- thanks for the initial feature and patience! |
This PR adds a feature for the CSS Typed OM Level 1.