-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds calc-size feature #2148
Merged
Merged
Adds calc-size feature #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little fix, but otherwise ready to merge. Thank you!
Co-authored-by: Daniel D. Beck <[email protected]>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 16, 2024
This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 16, 2024
This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 16, 2024
This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 17, 2024
…re use counters + test mappings, a=testonly Automatic update from web-platform-tests calc-size + interpolate-size WebDX feature use counters + test mappings This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940} -- wpt-commits: f15ff9f2ea676ee1a9821d7e046e21aae07eabf7 wpt-pr: 49212
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 18, 2024
…re use counters + test mappings, a=testonly Automatic update from web-platform-tests calc-size + interpolate-size WebDX feature use counters + test mappings This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940} -- wpt-commits: f15ff9f2ea676ee1a9821d7e046e21aae07eabf7 wpt-pr: 49212
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 20, 2024
…re use counters + test mappings, a=testonly Automatic update from web-platform-tests calc-size + interpolate-size WebDX feature use counters + test mappings This adds: * a WebFeature use counter for calc-size() * a WebDXFeature for both calc-size() and interpolate-size * WPT test mappings for both WebDX features The WebDX features are described at: https://web-platform-dx.github.io/web-features-explorer/features/calc-size/ https://web-platform-dx.github.io/web-features-explorer/features/interpolate-size/ and were added in: web-platform-dx/web-features#2110 web-platform-dx/web-features#2148 Bug: 313072 Change-Id: Id34d234aab6514b514f012688fafc4d6dec1d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6024690 Commit-Queue: David Baron <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1383940} -- wpt-commits: f15ff9f2ea676ee1a9821d7e046e21aae07eabf7 wpt-pr: 49212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from original PR here: #2111