wasm-string-builtins: add keys tagged in BCD
#2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These keys are tagged as part of the feature in BCD, but not here.
github-actions
bot
added
the
feature definition
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jan 18, 2025
Reading across the following links, it appears that Firefox implemented the same thing as Chrome, but when Chris added the `compile_options` keys they weren't reconciled with the existing Firefox data. - https://bugzilla.mozilla.org/show_bug.cgi?id=1863794 - mdn#25230 - mdn#25391 Discovered in the course of web-platform-dx/web-features#2549
ddbeck
commented
Jan 18, 2025
Comment on lines
+17
to
+28
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "130" | ||
| # chrome_android: "130" | ||
| # edge: "130" | ||
| - webassembly.api.Module.Module.compile_options | ||
| - webassembly.api.compileStreaming_static.compile_options | ||
| - webassembly.api.compile_static.compile_options | ||
| - webassembly.api.instantiateStreaming_static.compile_options | ||
| - webassembly.api.instantiate_static.compile_options | ||
| - webassembly.api.validate_static.compile_options |
There was a problem hiding this comment.
I believe the Firefox data for these key are wrong. See mdn/browser-compat-data#25706. This is pre-Baseline, so we probably don't need to block on that.
Elchi3
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jan 20, 2025
…5706) Show Firefox support across all of wasm JS string built-ins Reading across the following links, it appears that Firefox implemented the same thing as Chrome, but when Chris added the `compile_options` keys they weren't reconciled with the existing Firefox data. - https://bugzilla.mozilla.org/show_bug.cgi?id=1863794 - #25230 - #25391 Discovered in the course of web-platform-dx/web-features#2549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These keys are tagged as part of the feature in BCD, but not here.