Add several discouraged JavaScript features #2670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
| according_to: | ||
| - https://tc39.es/ecma262/multipage/additional-ecmascript-features-for-web-browsers.html#sec-additional-ecmascript-features-for-web-browsers | ||
| # No `alternatives` becuase it would be `alternatives: | ||
| # [object-object, functions]`. In the future it'd be nice to have an |
There was a problem hiding this comment.
Can you open an issue about this? It'd be nice to track this. I agree that being able to deep-link into existing features would be useful.
| @@ -0,0 +1,13 @@ | |||
| name: getYear() and setYear() | |||
| description: The `getYear()` and `setYear()` methods of `Date` objects get and set the year offset to 1900, changing a date's year in way that is subject to the year 2000 problem. | |||
There was a problem hiding this comment.
Suggested change
| description: The `getYear()` and `setYear()` methods of `Date` objects get and set the year offset to 1900, changing a date's year in way that is subject to the year 2000 problem. | |
| description: The `getYear()` and `setYear()` methods of `Date` objects get and set the year offset to 1900, changing a date's year in a way that is subject to the year 2000 problem. |
There was a problem hiding this comment.
Wondering if "the year 2000 problem" is showing our age a little bit :)
Joking aside, I wonder how many people who read this going forward will actually know what it refers to.
There was a problem hiding this comment.
It's a good point. Really, that's information more suited to a (probable future) discouragement reason field. How about this more matter-of-fact version?
Suggested change
| description: The `getYear()` and `setYear()` methods of `Date` objects get and set the year offset to 1900, changing a date's year in way that is subject to the year 2000 problem. | |
| description: The `getYear()` and `setYear()` methods of `Date` objects get and set the year as an offset to 1900. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several discouraged JavaScript features, building on @captainbrosset's work in #2564. The features are:
__defineGetter__()and__defineSetter__())Date.prototype.{get,set}Year()Date.prototype.toGMTString()escape()andunescape()global methodsString.prototype.blink())Object.prototype.__proto__RegExp.prototype.compile()Supersedes and closes #2564.