Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow shorthand feature (with clip values) #295

Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Aug 14, 2023

This corresponds to https://caniuse.com/css-overflow

This is a new feature. Here are some ideas for reviewing it:

  • Is this a reasonable identifier for the feature?
  • Does this have a reasonable spec link?
  • Does this have a reasonable caniuse reference?
  • Are the mdn/browser-compat-data features plausible pieces of the feature as a whole?
  • Are any pieces missing?
  • Are any of the listed features later additions, part of a distinct sub feature, or otherwise excludable?

@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Aug 15, 2023
@tidoust
Copy link
Member

tidoust commented Oct 18, 2023

CSS Overflow Module Level 4 extends overflow to also apply to "replaced elements". That's still being worked upon, I think, and seems at risk.

Assuming this goes through, the definitions of the CSS properties would remain unchanged, the scope of their application would change. I'm wondering how we could represent that evolution once css-overflow-4 becomes the base level. Would we just update the URL to https://drafts.csswg.org/css-overflow-4/#propdef-overflow?

@ddbeck
Copy link
Collaborator Author

ddbeck commented Nov 6, 2023

@tidoust I think the evolution would look something like this:

  1. When the first implementer ships overflow for replaced elements, then I'd expect a new feature to appear in BCD for the relevant properties (e.g., css.properties.overflow.applies_to_replaced_elements).
  2. At that point, we'd create a feature here (something like overflow-for-replaced-elements). We'd indicate it has some relationship to the overflow-shorthand (see Feature parent relationships #217 for more on that question).
  3. The march of time happens and browsers eventually implement the feature.
  4. A day comes when the overflow-for-replaced-elements feature is mature enough (and developers have ceased to distinguish it) that we merge the feature into the overflow-shorthand feature. (I imagine we'll have a guideline to cover this, something like a year after a feature has achieved some very high level of support.) See also: Consider handling feature identifier changes or aliases #91.

Does that feel like a practical approach? Or do you think we need to do some future-proofing today?

@tidoust
Copy link
Member

tidoust commented Nov 6, 2023

Does that feel like a practical approach? Or do you think we need to do some future-proofing today?

That works! I wasn't clear that there could be a more "abstract" (in the sense of not being a 1-to-1 mapping to a property value) entry in BCD such as css.properties.overflow.applies_to_replaced_elements. That seems a good approach to me.

@ddbeck ddbeck merged commit 279a0f7 into web-platform-dx:main Nov 20, 2023
@ddbeck ddbeck deleted the 2023-08-14-add-feature-1-css-overflow branch November 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants