Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Need to add in the verifyGenericRolesBySelector() call missing from a few files #111

Closed
cookiecrook opened this issue Mar 15, 2024 · 3 comments · Fixed by web-platform-tests/wpt#45174
Assignees
Labels
good first issue Good for newcomers

Comments

@cookiecrook
Copy link
Collaborator

If #109 doesn't land, we need to add in the verifyGenericRolesBySelector() call missing from a few files: tab-roles.html and list-roles.html.... (see diff in web-platform-tests/wpt/pull/45032 but wait for a decision on #109 to avoid potential conflict.)

@nmlapre
Copy link

nmlapre commented Mar 15, 2024

Besides tab-roles.html and list-roles.html, I think we're also missing the .ex-generic check in menu-roles.html (see these tests). Looks like it's five total tests across these files that are checked in but not running.

I'm happy to do this when I get a chance, on resolution of #109.

@cookiecrook
Copy link
Collaborator Author

r+ on #109 btw. thanks.

@cookiecrook cookiecrook changed the title Task: If #109 doesn't land, we need to add in the verifyGenericRolesBySelector() call missing from a few files Task: Need to add in the verifyGenericRolesBySelector() call missing from a few files Mar 25, 2024
@cookiecrook cookiecrook added the good first issue Good for newcomers label Mar 25, 2024
@nmlapre
Copy link

nmlapre commented Mar 28, 2024

Can't assign myself to this issue, but see the PR fixing this problem here: web-platform-tests/wpt#45174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants