Enable missed '.ex-generic' orphaned role tests #45174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds calls to verifyGenericRolesBySelector in three test files, where those calls are missing. There are orphaned role tests sitting in each file that use the 'ex-generic' class, but since we're not calling verifyGenericRolesBySelector, they aren't running. This commit fixes that problem.
cookiecrook
approved these changes
Mar 28, 2024
|
Closing and reopening to kick the CI bots. |
|
I don't see anything obvious in the CI logs that would explain the failure as being test-specific. Try to close/open tomorrow to kick the CI bots or file the failure as a standalone WPT harness issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes web-platform-tests/interop-accessibility#111
This commit adds calls to
verifyGenericRolesBySelectorin three test files, where those calls are missing. There are orphaned role tests sitting in each file that use the 'ex-generic' class, but since we're not callingverifyGenericRolesBySelector, they aren't running. This commit fixes that problem.