-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accname/name/comp_text_node.html tests that assume   trimming #115
Comments
Who can move this to https://github.com/web-platform-tests/interop-accessibility ? IIRC the test predates a spec clarification that it should be ASCII whitespace. |
Thanks @nt1m |
Sounds like both the spec & test will be updated here, from what I'm hearing. |
Correct. That is the consensus from the ARIA WG call. |
@jnurthen asks if there are similar tests for trimming value of html alt attr... |
For https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element%3Athe-img-element-11 |
I plan to work on this imminently. |
FWIW, I don't believe a counterpart spec change is needed... Both the published version and the editor's draft reference ASCII whitespace (which does not include non-breaking space) in this step of the AccName algorithm. https://www.w3.org/TR/accname-1.2/#comp_label |
…abel tests, a=testonly Automatic update from web-platform-tests Interop: Remove invalid nbsp trimming label tests (#45794) Resolves web-platform-tests/interop-accessibility#115 -- wpt-commits: f90c59598faaad9c60f43fff9db4e9873c7a6b54 wpt-pr: 45794
…abel tests, a=testonly Automatic update from web-platform-tests Interop: Remove invalid nbsp trimming label tests (#45794) Resolves web-platform-tests/interop-accessibility#115 -- wpt-commits: f90c59598faaad9c60f43fff9db4e9873c7a6b54 wpt-pr: 45794
…abel tests, a=testonly Automatic update from web-platform-tests Interop: Remove invalid nbsp trimming label tests (#45794) Resolves web-platform-tests/interop-accessibility#115 -- wpt-commits: f90c59598faaad9c60f43fff9db4e9873c7a6b54 wpt-pr: 45794
Test List
The following tests in accname/name/comp_text_node.html:
Rationale
The tests all validate that
at the beginning and end of a node's computed name is trimmed, e.g.:<span role="button" tabindex="0" class="ex" data-expectedlabel="button label" data-testname="span[role=button] with text node, with leading/trailing non-breaking space"> button label </span>
Chromium and Safari fail the tests because they do not trim the
s.The accname computation steps do not say anything about trimming whitespace from the computed result. I found an older issue seeking clarification about this that is not yet resolved: w3c/accname#95. The WPT utils used for these tests do some of their own whitespace normalizing (added here) but that explicitly does not include non-breaking spaces.
Given that the behavior validated by the tests is not stated in the spec, and web-platform-tests/interop#95 does not seem close to a resolution, I'm proposing that these tests be removed from Interop2024.
cc @cookiecrook
The text was updated successfully, but these errors were encountered: