refactor aria-utils #29
Assignees
Labels
Comments
|
Agenda+ to get an r+ |
cookiecrook
added a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 6, 2023
Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jun 13, 2023
…y ID usage, a=testonly Automatic update from web-platform-tests refactor aria-utils to remove unnecessary ID usage (#39724) Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage. -- wpt-commits: 886b8496dcfb6f9489f57867a1767eee244414f8 wpt-pr: 39724
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this issue
Jun 14, 2023
…y ID usage, a=testonly Automatic update from web-platform-tests refactor aria-utils to remove unnecessary ID usage (#39724) Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage. -- wpt-commits: 886b8496dcfb6f9489f57867a1767eee244414f8 wpt-pr: 39724
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Jun 16, 2023
…y ID usage, a=testonly Automatic update from web-platform-tests refactor aria-utils to remove unnecessary ID usage (#39724) Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage. -- wpt-commits: 886b8496dcfb6f9489f57867a1767eee244414f8 wpt-pr: 39724 UltraBlame original commit: 2e5571db57132b0acd6a65e8baf83a2fc4d4ad5b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Jun 16, 2023
…y ID usage, a=testonly Automatic update from web-platform-tests refactor aria-utils to remove unnecessary ID usage (#39724) Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage. -- wpt-commits: 886b8496dcfb6f9489f57867a1767eee244414f8 wpt-pr: 39724 UltraBlame original commit: 2e5571db57132b0acd6a65e8baf83a2fc4d4ad5b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Jun 16, 2023
…y ID usage, a=testonly Automatic update from web-platform-tests refactor aria-utils to remove unnecessary ID usage (#39724) Resolves web-platform-tests/interop-accessibility#29 Refactors aria-utils to remove unnecessary ID usage. -- wpt-commits: 886b8496dcfb6f9489f57867a1767eee244414f8 wpt-pr: 39724 UltraBlame original commit: 2e5571db57132b0acd6a65e8baf83a2fc4d4ad5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
After web-platform-tests/wpt#39604 lands, refactor aria-utils.js to avoid assigning an ID if it doesn't have to... I thought I had tried that initially, but assumed it didn't work without an ID once the scope was passed to the webdriver context...
In hindsight, I must've just had a bug, because it clearly works without an ID in @nolanlawson's patch for web-platform-tests/wpt#36541
This will likely remove the ID check and assignment loops in all three of the methods inside aria-utils.js, and then pass in the element ref directly to the async getter.
The text was updated successfully, but these errors were encountered: