-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typography bucket #13
Comments
If we want to add more typography things to this, we could add support for the IC unit. It's a unit important for typesetting CJK scripts. |
This comment has been minimized.
This comment has been minimized.
If you're thinking of improving support (and interop) for text in CJK scripts, can I propose supporting the Segment Break Transformation rules, which have the potential to make CJK authors' lives considerably better: |
I think it would be useful to decide which are the highest priority areas in this proposal. Including all the specs/properties mentioned seems like it would end up with something that's too broad, and runs the risk of different implementations picking different subsets to prioritise, so not improving the actual interop. Is there data we can use to help narrow the scope to the features with highest impact? |
Tests for Segment Break Transformation |
These are in Firefox and Safari but not in Chrome, and the subject of an Interop 2022 proosal: web-platform-tests/interop#13
These are in Firefox and Safari but not in Chrome, and the subject of an Interop 2022 proposal: web-platform-tests/interop#13
The Chromium bugs for @jensimmons regarding the advice to use If so, I see that usage of |
These are in Firefox and Safari but not in Chrome, and the subject of an Interop 2022 proposal: web-platform-tests/interop#13
it is |
I like to withdraw the suggestion of widows & orphans. While this functionality is highly requested, I don't believe that the current spec solves the problem we designers & developers have. Instead, I believe font-size-adjust and/or text-size-adjust would be a better addition to this bucket. |
@foolip
Interop 2022 can help with this. Let's finish these features & make Fonts 4 complete. |
I'm hearing desire for Color Fonts as well: https://drafts.csswg.org/css-fonts-4/#color-font-support |
So, can we clarify what the actual proposal here is? It's difficult to understand what people think forms part of the final state of this proposal, and if we don't know that it's not possible to take a stance on it (or at least not a positive stance). |
So, concretely, I believe our proposal is: General Typography
CJK TypographySplitting this out, mostly for the sake of clarity; this being split out shouldn't be taken as any suggestion that these should be in any way lower priority.
|
Along with CJK Typography, it's probably worth including CJK text encoding, particularly iso-2022-jp, gbk, and gb18030 |
Tests for those encodings are here: Edit: https://wpt.fyi/results/encoding?q=iso-2022-jp- too for ISO-2022-JP. |
I found https://github.com/WebKit/WebKit/tree/main/LayoutTests/fast/css-generated-content but I can't find any tests in Gecko (or Chromium) beyond what's imported from WPT. How comprehensive are the WebKit tests, and do they match the current spec? |
For Segment Break Transformation Rules, the spec has UA-defined behavior:
I only looked into this feature today so my misunderstanding is surface deep, but doesn't this make most of the interesting cases UA-defined? A bunch of the tests were marked tentative in web-platform-tests/wpt#26588 due to w3c/csswg-drafts#5086, which is still open. |
Yeah, that's unfortunate.... there used to be quite a bit more in the spec, but then details were deferred to Text-4 following the discussion in w3c/csswg-drafts#5086 (comment). So I guess we'd need to push that spec work forward if any real progress is going to happen here. (FWIW, I think Gecko implemented something close to what used to be in the Text-3 draft up until a year ago, though there may have been some edge cases where it didn't entirely conform.) |
I see. w3c/csswg-drafts@b3bb0ed seems to be the commit that commented out the rules around this. |
@gsnedders said on the Matrix channel:
I agree. Does anyone have suggestions for another name for this bucket? Or could it make sense to slot encodings under the webcompat bucket, if it has caused any broken sites? @achristensen07 WDYT? |
What about "Font Parametrization bucket"? |
@karlcow https://encoding.spec.whatwg.org/ doesn't really fit well under that banner either. But @annevk suggested just "text" which I think would work. |
I've labelled them as |
Thanks @gsnedders! It would be great if someone from each browser engine team can look over |
The |
From the discussion earlier, @foolip was going to remove many of the tests in These are the tests which don't pass everywhere, which is 8 tests rather than 1209 tests. However, even among those 8 many of those are any.js tests, and it's unclear there's any value to running those in different environments. Do we just want to go down to these five tests? |
web-platform-tests/wpt-metadata#2388 does duly remove the vast majority of the tests (down to six, keeping decode & encode tests for each of three encodings, despite gb18030 encode being interop already). |
For reference, this is what we debated and decided.
|
Description
After web fonts were defined, and before variable fonts were invented, the CSS Font specification added powerful tooling for web designers & developers to use to create refined typography.
font-feature-settings
is a CSS property that addresses the low-level plumbing for these ability. It has broad support across almost all browsers.However, Authors are encouraged to never use
font-feature-settings
, and instead usefont-variant-*
.Authors cannot currently follow this advice, because not all browser have implemented all of the
font-variant-*
properties. This is holding back typography on the web.Specifically, these two need to be implemented in Chromium:
Specification
CSS Fonts Module Level 4
Tests
font-variant-* tests
Rationale
State of CSS Survey 2021 reveals requests for typography improvements.
The text was updated successfully, but these errors were encountered: