Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not react to closed pull requests #53

Closed
jugglinmike opened this issue Nov 19, 2018 · 1 comment
Closed

Do not react to closed pull requests #53

jugglinmike opened this issue Nov 19, 2018 · 1 comment

Comments

@jugglinmike
Copy link
Contributor

This project updates pull requests when they are closed. That event does not indicate any meaningful change, but in rare cases (e.g. WPT pull request 12553) it may cause the script to make irrelevant modifications to the pull request. The "closed" event ought to be ignored.
@foolip
Copy link
Member

foolip commented Nov 30, 2018

I think this is a dupe of #38.

@Hexcles Hexcles closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foolip @jugglinmike @Hexcles