-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do nothing with closed PRs #38
Comments
@jugglinmike do you think this was accidentally fixed by #73? |
#69 is related. I just saw on web-platform-tests/wpt#13606 that this hasn't been fixed, the bot added back labels and reviewers that I removed before making a comment, thus spamming everyone. |
`pull_request.merged` implies `pull_request.state != "open"` but the latter will also be true for closed but unmerged pull requests. Fixes #38.
This bug just caused a whole lot of spam in web-platform-tests/wpt#13606 so I submitted #86. @Ms2ger you asked there what I did but I won't reply there until this issue is fixed to avoid more spam. I just came along to try an understand the mishap, I didn't cause it. I can't pin down which force push it was, but probably one of the force pushes @woaiwyhty did on that PR either rebased a whole lot of history to new distinct commits, or contained a merge commit that had the same effect. |
This is not plain refactoring, as the `state == "closed"` condition replaces the check on `merged`. It also ensures that we perform the same checks both on the event payload and on the response from https://developer.github.com/v3/pulls/#get-a-single-pull-request. Fixes #38. Fixes #69.
This is not plain refactoring, as the `state == "closed"` condition replaces the check on `merged`. It also ensures that we perform the same checks both on the event payload and on the response from https://developer.github.com/v3/pulls/#get-a-single-pull-request. Fixes #38. Fixes #69.
This is not plain refactoring, as the `state == "closed"` condition replaces the check on `merged`. It also ensures that we perform the same checks both on the event payload and on the response from https://developer.github.com/v3/pulls/#get-a-single-pull-request. Fixes #38. Fixes #69.
This is not plain refactoring, as the `state == "closed"` condition replaces the check on `merged`. It also ensures that we perform the same checks both on the event payload and on the response from https://developer.github.com/v3/pulls/#get-a-single-pull-request. Fixes #38. Fixes #69.
On web-platform-tests/wpt#11122 @wpt-pr-bot changed the reviewers of a PR as I closed it. That generated email for me which wasn't very help. I suggest that when a PR is closed @wpt-pr-bot never does anything.
The text was updated successfully, but these errors were encountered: