Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move interop data outside of static (fixes #3132) #3201

Closed

Conversation

racheljay
Copy link
Contributor

Description

This PR moves the data that was previously in components/static/interop-data.json to a .js file outside of the static directory as outlined in the discussion for #3142.

Changes

components/static/interop-data.json was previously removed and this PR adds that data to components/interop-data.js. It is now imported directly into interop.js and accessed by fetchYearData().

@racheljay racheljay marked this pull request as ready for review March 14, 2023 00:16
@racheljay
Copy link
Contributor Author

I don't have permission to request reviewers but this is ready for review @DanielRyanSmith @KyleJu. I'm also getting a failing check that looks to be caused by a permissions issue/missing client secret file.

@KyleJu
Copy link
Collaborator

KyleJu commented Mar 14, 2023

I don't have permission to request reviewers but this is ready for review @DanielRyanSmith @KyleJu. I'm also getting a failing check that looks to be caused by a permissions issue/missing client secret file.

@racheljay Would you mind trying uploading this PR from a branch, rather than a fork? I think there are credential protections for PRs from a fork.

@racheljay
Copy link
Contributor Author

I don't have permission to request reviewers but this is ready for review @DanielRyanSmith @KyleJu. I'm also getting a failing check that looks to be caused by a permissions issue/missing client secret file.

@racheljay Would you mind trying uploading this PR from a branch, rather than a fork? I think there are credential protections for PRs from a fork.

I tried doing a direct push but I am getting this error:
ERROR: Permission to web-platform-tests/wpt.fyi.git denied to racheljay.
The repo settings might need to be updated to allow me to push.

@KyleJu
Copy link
Collaborator

KyleJu commented Mar 14, 2023

I don't have permission to request reviewers but this is ready for review @DanielRyanSmith @KyleJu. I'm also getting a failing check that looks to be caused by a permissions issue/missing client secret file.

@racheljay Would you mind trying uploading this PR from a branch, rather than a fork? I think there are credential protections for PRs from a fork.

I tried doing a direct push but I am getting this error: ERROR: Permission to web-platform-tests/wpt.fyi.git denied to racheljay. The repo settings might need to be updated to allow me to push.

I just added you as a collaborator to this project. You should be able to push after accepting the invite! Let me know if you have any other questions

@racheljay
Copy link
Contributor Author

Thanks @KyleJu! It looks like I can't convert this PR so I'll close it and make a new one.

@racheljay racheljay closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants