-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix whitespace handling inside CSS variables.
As per w3c/csswg-drafts#881 and w3c/csswg-drafts#774. Differential Revision: https://phabricator.services.mozilla.com/D116459 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1713787 gecko-commit: d55d07d3e8ccfa9a6bd619e5a1863927e45d3aae gecko-reviewers: xidorn
- Loading branch information
1 parent
e5ead56
commit 198dd87
Showing
16 changed files
with
43 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,15 +3,15 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test declaring a variable with invalid syntax due to a variable reference having no tokens in its fallback.</title> | ||
| <title>CSS Test: Test declaring a variable with valid syntax due to a variable reference having no tokens in its fallback.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#syntax"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| p { | ||
| color: red; | ||
| --a: green; | ||
| --b: crimson; | ||
| --a: crimson; | ||
| --b: green; | ||
| --a: var(--b,); | ||
| color: var(--a); | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,15 +3,15 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test declaring a variable with invalid syntax due to a variable reference having only a comment in its fallback.</title> | ||
| <title>CSS Test: Test declaring a variable with a variable reference having only a comment in its fallback.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#syntax"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| p { | ||
| color: red; | ||
| --a: green; | ||
| --b: crimson; | ||
| --a: crimson; | ||
| --b: green; | ||
| --a: var(--b,/**/); | ||
| color: var(--a); | ||
| } | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,17 +3,17 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test declaring a non-custom property with invalid syntax due to having a variable reference whose fallback contains no tokens.</title> | ||
| <title>CSS Test: Test declaring a non-custom property with a variable reference whose fallback contains no tokens.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#using-variables"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { | ||
| --a: crimson; | ||
| --a: green; | ||
| color: red; | ||
| } | ||
| p { | ||
| color: green; | ||
| color: crimson; | ||
| color: var(--a,); | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,17 +3,17 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test declaring a non-custom property with invalid syntax due to having a variable reference whose fallback contains nothing but a comment.</title> | ||
| <title>CSS Test: Test declaring a non-custom property with a variable reference whose fallback contains nothing but a comment.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#using-variables"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { | ||
| --a: crimson; | ||
| --a: green; | ||
| color: red; | ||
| } | ||
| p { | ||
| color: green; | ||
| color: crimson; | ||
| color: var(--a,/**/); | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test a failing non-custom property declaration in an @supports rule where the property value contains a syntactically invalid variable reference due to having no fallback tokens.</title> | ||
| <title>CSS Test: Test a non-custom property declaration in an @supports rule where the property value contains a variable reference having no fallback tokens.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#using-variables"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { color: red; } | ||
| @supports (color: var(--a)) and (not (color: var(--a,))) { | ||
| @supports (color: var(--a)) and (color: var(--a,)) { | ||
| p { color: green; } | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test a failing non-custom property declaration in an @supports rule where the property value contains a syntactically invalid variable reference due to having no fallback tokens, just a comment.</title> | ||
| <title>CSS Test: Test a non-custom property declaration in an @supports rule where the property value contains a variable reference having no fallback tokens, just a comment.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#using-variables"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { color: red; } | ||
| @supports (color: var(--a)) and (not (color: var(--a,/**/))) { | ||
| @supports (color: var(--a)) and (color: var(--a,/**/)) { | ||
| p { color: green; } | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test a failing custom property declaration in an @supports rule whose value contains a variable reference with no fallback tokens.</title> | ||
| <title>CSS Test: Test a custom property declaration in an @supports rule whose value contains a variable reference with no fallback tokens.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#syntax"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { color: red; } | ||
| @supports (--a: a) and (not (--a: var(--b,))) { | ||
| @supports (--a: a) and (--a: var(--b,)) { | ||
| p { color: green; } | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,13 @@ | |
| http://creativecommons.org/publicdomain/zero/1.0/ | ||
| --> | ||
| <!DOCTYPE html> | ||
| <title>CSS Test: Test a failing custom property declaration in an @supports rule whose value contains a variable reference with no fallback tokens, just a comment.</title> | ||
| <title>CSS Test: Test a property declaration in an @supports rule whose value contains a variable reference with no fallback tokens, just a comment.</title> | ||
| <link rel="author" title="Cameron McCormack" href="mailto:[email protected]"> | ||
| <link rel="help" href="http://www.w3.org/TR/css-variables-1/#syntax"> | ||
| <link rel="match" href="support/color-green-ref.html"> | ||
| <style> | ||
| body { color: red; } | ||
| @supports (--a: a) and (not (--a: var(--b,/**/))) { | ||
| @supports (--a: a) and (--a: var(--b,/**/)) { | ||
| p { color: green; } | ||
| } | ||
| </style> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters