Skip to content

Commit

Permalink
Revert "bindings: Implement timers with V8Function"
Browse files Browse the repository at this point in the history
This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> bindings: Implement timers with V8Function
>
> This fixes bug 866610 by using the IDL infrastructure to properly enter
> the v8::Context before calling the registered callback.
>
> Also ensure eager finalization of ScheduledAction in DOMTimer to
> prevent a memory leak. Added two more effective DCHECKs to confirm.
>
> Bug: 866610
> Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
> Reviewed-on: https://chromium-review.googlesource.com/1220486
> Reviewed-by: Nate Chapin <[email protected]>
> Reviewed-by: Yuki Shiino <[email protected]>
> Reviewed-by: Hitoshi Yoshida <[email protected]>
> Commit-Queue: Timothy Gu <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#593108}

[email protected],[email protected],[email protected],[email protected],[email protected]

Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866610
Reviewed-on: https://chromium-review.googlesource.com/1239216
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593260}
  • Loading branch information
liberato-at-chromium authored and chromium-wpt-export-bot committed Sep 21, 2018
1 parent 2719d8f commit 45f38e4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 22 deletions.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion lint.whitelist
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ SET TIMEOUT: html/semantics/embedded-content/the-img-element/*
SET TIMEOUT: html/semantics/scripting-1/the-script-element/*
SET TIMEOUT: html/webappapis/dynamic-markup-insertion/opening-the-input-stream/0*
SET TIMEOUT: html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/history-frame.html
SET TIMEOUT: html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/url-entry-document-timer-frame.html
SET TIMEOUT: html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.js
SET TIMEOUT: html/webappapis/scripting/event-loops/*
SET TIMEOUT: html/webappapis/scripting/events/event-handler-processing-algorithm-error/*
Expand Down

0 comments on commit 45f38e4

Please sign in to comment.