Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "bindings: Implement timers with V8Function"
This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173. Reason for revert: <INSERT REASONING HERE> Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <[email protected]> > Reviewed-by: Yuki Shiino <[email protected]> > Reviewed-by: Hitoshi Yoshida <[email protected]> > Commit-Queue: Timothy Gu <[email protected]> > Cr-Commit-Position: refs/heads/master@{#593108} [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610 Reviewed-on: https://chromium-review.googlesource.com/1239216 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Frank Liberato <[email protected]> Cr-Commit-Position: refs/heads/master@{#593260}
- Loading branch information