Skip to content

Commit

Permalink
Do not require user gesture if pictureInPictureElement is set
Browse files Browse the repository at this point in the history
Following w3c/picture-in-picture#116, it
would be great to allow video to enter Picture-in-Picture without user
activation if there's already a visible PiP window in the context of the
document, in other words if `document.pictureInPictureElement` is set.

Bug: 928697
Change-Id: I2c191368d8dd1bd6ddade719399d0679ef410575
Reviewed-on: https://chromium-review.googlesource.com/c/1454360
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#630026}
  • Loading branch information
beaufortfrancois authored and chromium-wpt-export-bot committed Feb 7, 2019
1 parent dcc3641 commit 5692bc8
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions picture-in-picture/request-picture-in-picture-twice.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,13 @@
await promise_rejects(t, 'NotAllowedError', video2.requestPictureInPicture());
return promise;
}, 'request Picture-in-Picture consumes user gesture');

promise_test(async t => {
const video1 = await loadVideo();
const video2 = await loadVideo();
await test_driver.bless('request Picture-in-Picture');
await video1.requestPictureInPicture();
assert_equals(document.pictureInPictureElement, video1);
return video2.requestPictureInPicture();
}, 'request Picture-in-Picture does not require user gesture if document.pictureInPictureElement is set');
</script>

0 comments on commit 5692bc8

Please sign in to comment.