Skip to content

Commit

Permalink
Rename "window-placement" permission to "window-management" in web pl…
Browse files Browse the repository at this point in the history
…atform tests.

Rename "window-placement" permission to
"window-management" in web platform tests.

Bug: 1328581
Change-Id: I983a8e4e20393b973d69be86ed11eb048df07016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000319
Reviewed-by: Mike Wasserman <[email protected]>
Commit-Queue: Brad Triebwasser <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1103075}
  • Loading branch information
bradtriebwasser authored and chromium-wpt-export-bot committed Feb 9, 2023
1 parent 68e9d5a commit 73906df
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
<script>
promise_test(async (t) => {
await test_driver.set_permission(
{ name: "window-placement" },
{ name: "window-management" },
"granted"
);

10 changes: 5 additions & 5 deletions screen-details/getScreenDetails.tentative.https.window.js
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ promise_test(async t => {
}, 'getScreenDetails() is present');

promise_test(async t => {
await test_driver.set_permission({name: 'window-placement'}, 'granted');
await test_driver.set_permission({name: 'window-management'}, 'granted');
const screenDetails = await self.getScreenDetails();
assert_true(ScreenDetails.prototype.isPrototypeOf(screenDetails));
assert_true(ScreenDetailed.prototype.isPrototypeOf(screenDetails.currentScreen));
@@ -19,14 +19,14 @@ promise_test(async t => {
}, 'getScreenDetails() returns the expected interface with permission granted');

promise_test(async t => {
await test_driver.set_permission({name: 'window-placement'}, 'granted');
await test_driver.set_permission({name: 'window-management'}, 'granted');
assert_greater_than((await self.getScreenDetails()).screens.length, 0);
await test_driver.set_permission({name: 'window-placement'}, 'denied');
await test_driver.set_permission({name: 'window-management'}, 'denied');
await promise_rejects_dom(t, 'NotAllowedError', self.getScreenDetails());
}, 'getScreenDetails() rejects the promise with permission denied');

promise_test(async t => {
await test_driver.set_permission({name: 'window-placement'}, 'granted');
await test_driver.set_permission({name: 'window-management'}, 'granted');
let iframe = document.body.appendChild(document.createElement('iframe'));
assert_greater_than((await iframe.contentWindow.getScreenDetails()).screens.length, 0);

@@ -50,7 +50,7 @@ promise_test(async t => {
}, 'getScreenDetails() resolves for attached iframe; rejects for detached iframe');

promise_test(async t => {
await test_driver.set_permission({name: 'window-placement'}, 'granted');
await test_driver.set_permission({name: 'window-management'}, 'granted');
let iframe = document.body.appendChild(document.createElement('iframe'));
const screenDetails = await iframe.contentWindow.getScreenDetails();
assert_greater_than(screenDetails.screens.length, 0);
8 changes: 4 additions & 4 deletions screen-details/permission.https.window.js
Original file line number Diff line number Diff line change
@@ -4,17 +4,17 @@
"use strict";

promise_test(async t => {
await test_driver.set_permission({ name: "window-placement" }, "denied");
await test_driver.set_permission({ name: "window-management" }, "denied");

const status = await navigator.permissions.query({ name:"window-placement" });
const status = await navigator.permissions.query({ name:"window-management" });
assert_class_string(status, "PermissionStatus");
assert_equals(status.state, "denied");
}, "Deny window management permission should work.");

promise_test(async t => {
await test_driver.set_permission({ name: "window-placement" }, "granted");
await test_driver.set_permission({ name: "window-management" }, "granted");

const status = await navigator.permissions.query({ name: "window-placement" });
const status = await navigator.permissions.query({ name: "window-management" });
assert_class_string(status, "PermissionStatus");
assert_equals(status.state, "granted");
}, "Grant window management permission should work.");
2 changes: 1 addition & 1 deletion window-placement/resources/helpers.js
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ async function setUpWindowManagement(setUpTest, setUpButton) {
log(`WARNING: Run via 'wpt serve'; file URLs lack permission support`);

try { // Support manual testing where test_driver is not running.
await test_driver.set_permission({ name: 'window-placement' }, 'granted');
await test_driver.set_permission({ name: 'window-management' }, 'granted');
} catch {
}
const setUpWatcher = new EventWatcher(setUpTest, setUpButton, ['click']);

0 comments on commit 73906df

Please sign in to comment.