Skip to content

Commit

Permalink
Remove CSSSystemColorComputeToSelf
Browse files Browse the repository at this point in the history
In w3c/csswg-drafts#6773, CSSWG resolved to
reverse the decision to support this feature, so remove the feature
flag and all related code and tests.

[email protected]

Bug: 1081945
Change-Id: If38641559b530b44dc0eb054f485974145bd316c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3718880
Reviewed-by: Alison Maher <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Daniel Libby <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1019741}
  • Loading branch information
dlibby- authored and chromium-wpt-export-bot committed Jun 30, 2022
1 parent ab6644c commit 9f8d726
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions css/css-color/system-color-compute.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<title>CSS Color 4: System colors should compute to themselves</title>
<title>CSS Color 4: System colors compute to absolute colors</title>
<link rel="help" href="https://www.w3.org/TR/css-color-4/#resolving-color-values">
<meta name="assert" content="Tests if system color keywords compute to themselves">
<meta name="assert" content="Tests that system color keywords resolve to absolute colors at computed value time">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
Expand Down Expand Up @@ -57,12 +57,13 @@
</div>

<script>
// The premise behind this test is that if a system color keyword computes to
// itself, then child elements inheriting a system color value will inherit
// the keyword, not the color it resolves to. We can detect this by applying
// different color schemes to parent and child, then comparing the results we
// get between a child that inherited a system color versus a child that
// received the system color directly.
// The premise behind this test is that if a system color keyword were to
// compute to itself, then child elements inheriting a system color value
// will incorrectly inherit the keyword, not the color it resolves to. We can
// detect whether this is happening by applying different color schemes to
// parent and child, then comparing the results we get between a child that
// inherited a system color versus a child that received the system color
// directly.

// As a precondition check, validate that the color-scheme property results
// in a different resolved color.
Expand Down

0 comments on commit 9f8d726

Please sign in to comment.