-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari failing infrastructure tests #12621
Comments
Do we want to workaround these bugs, because they aren't per-se Safari running tests incorrectly? Except maybe the bless.html one? |
@cdumez @youennf could either of you help triage https://bugs.webkit.org/show_bug.cgi?id=187052? |
I cced some folks on bugs.webkit.org. |
@youennf it's not a big problem, but in order to run infrastructure/ tests in CI (foolip#5) to ensure that Safari doesn't regress, we'll need to check in expectations about every failure in infrastructure/. That in turn is in service of #13299, i.e., preventing regressions of non-infrastructure tests in Safari before they happen. Understanding why the tests are failing would be great even if it's not fixed soon. |
For bless.html, this is the failing test: promise_test(() => {
const video = document.createElement('video');
video.setAttribute('src', '/media/counting.ogv');
document.body.appendChild(video);
return test_driver.bless('start video playback', () => video.play())
}, 'user activation'); And the failure is Switching to /media/counting.mp4 seems to fix the problem. However, with the same fix, I've also seen flaky timeout or failure due to Running the tests flips back and forth a lot between the two tabs, which is #10398. My best guess is that media playback is being paused or prevented to start in background tabs. Anyway, this test doesn't need a media resource as well. Browsers that don't allow media playback without a user gesture will leave |
See diagnosis of Safari Technology Preview failure: #12621 (comment) This test does not need to load any media resource or consider the state of the returned promise.
I've sent #13403 to fix bless.html. |
See diagnosis of Safari Technology Preview failure: #12621 (comment) This test does not need to load any media resource or consider the state of the returned promise.
@youennf probably nothing; https://bugs.webkit.org/show_bug.cgi?id=187052 is the most annoying given it makes it hard to verify behaviour is correct. |
…ver.bless` test, a=testonly Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403) See diagnosis of Safari Technology Preview failure: web-platform-tests/wpt#12621 (comment) This test does not need to load any media resource or consider the state of the returned promise. -- wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f wpt-pr: 13403
…ver.bless` test, a=testonly Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403) See diagnosis of Safari Technology Preview failure: web-platform-tests/wpt#12621 (comment) This test does not need to load any media resource or consider the state of the returned promise. -- wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f wpt-pr: 13403
The test infrastructure/assumptions/allowed-to-play.html test I added in #13622 is also failing in Safari Technology Preview 67. |
I've filed https://bugs.webkit.org/show_bug.cgi?id=190775 for that. |
Downgrading the priority, this isn't causing any widespread trouble it seems. |
…ver.bless` test, a=testonly Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403) See diagnosis of Safari Technology Preview failure: web-platform-tests/wpt#12621 (comment) This test does not need to load any media resource or consider the state of the returned promise. -- wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f wpt-pr: 13403 UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
…ver.bless` test, a=testonly Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403) See diagnosis of Safari Technology Preview failure: web-platform-tests/wpt#12621 (comment) This test does not need to load any media resource or consider the state of the returned promise. -- wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f wpt-pr: 13403 UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
…ver.bless` test, a=testonly Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403) See diagnosis of Safari Technology Preview failure: web-platform-tests/wpt#12621 (comment) This test does not need to load any media resource or consider the state of the returned promise. -- wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f wpt-pr: 13403 UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
So current issues:
With that being the status now, I don't know if it makes sense to keep the meta issue open? |
With Safari TP 63:
test_driver.bless
test #13403The text was updated successfully, but these errors were encountered: