Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari failing infrastructure tests #12621

Open
2 of 4 tasks
gsnedders opened this issue Aug 22, 2018 · 11 comments
Open
2 of 4 tasks

Safari failing infrastructure tests #12621

gsnedders opened this issue Aug 22, 2018 · 11 comments

Comments

@gsnedders
Copy link
Member

gsnedders commented Aug 22, 2018

With Safari TP 63:

/infrastructure/assumptions/html-elements.html
  FAIL Compare CSS div definitions (only valid if pre-reqs pass) - assert_equals: Different value for -webkit-mask-box-image-slice expected "0" but got "0 fill"
http://web-platform.test:8000/infrastructure/assumptions/html-elements.html:71:20
step@http://web-platform.test:8000/resources/testharness.js:1553:30
test@http://web-platform.test:8000/resources/testharness.js:544:22
global code@http://web-platform.test:8000/infrastructure/assumptions/html-elements.html:58:5
  FAIL Compare CSS span definitions (only valid if pre-reqs pass) - assert_equals: Different value for -webkit-mask-box-image-slice expected "0" but got "0 fill"
http://web-platform.test:8000/infrastructure/assumptions/html-elements.html:88:18
step@http://web-platform.test:8000/resources/testharness.js:1553:30
test@http://web-platform.test:8000/resources/testharness.js:544:22
global code@http://web-platform.test:8000/infrastructure/assumptions/html-elements.html:76:5
/infrastructure/server/context.any.sharedworker.html
  FAIL context - ReferenceError: Can't find variable: SharedWorker
global code@http://web-platform.test:8000/infrastructure/server/context.any.sharedworker.html:8:41
/infrastructure/server/context.any.serviceworker.html
  FAIL context - assert_true: expected true got undefined
https://web-platform.test:8443/infrastructure/server/context.any.js:5:18
step@https://web-platform.test:8443/resources/testharness.js:1553:30
test@https://web-platform.test:8443/resources/testharness.js:544:22
global code@https://web-platform.test:8443/infrastructure/server/context.any.js:2:5
importScripts@[native code]
global code@https://web-platform.test:8443/infrastructure/server/context.any.worker.js:8:14
/infrastructure/server/order-of-metas.any.sharedworker.html
  FAIL foo - ReferenceError: Can't find variable: SharedWorker
global code@http://web-platform.test:8000/infrastructure/server/order-of-metas.any.sharedworker.html:9:41
/infrastructure/server/secure-context.https.any.serviceworker.html
  FAIL Use of .https file name flag implies secure context - assert_true: expected true got undefined
https://web-platform.test:8443/infrastructure/server/secure-context.https.any.js:3:14
step@https://web-platform.test:8443/resources/testharness.js:1553:30
test@https://web-platform.test:8443/resources/testharness.js:544:22
global code@https://web-platform.test:8443/infrastructure/server/secure-context.https.any.js:2:5
importScripts@[native code]
global code@https://web-platform.test:8443/infrastructure/server/secure-context.https.any.worker.js:8:14
/infrastructure/server/secure-context.https.any.sharedworker.html
  FAIL secure-context - ReferenceError: Can't find variable: SharedWorker
global code@https://web-platform.test:8443/infrastructure/server/secure-context.https.any.sharedworker.html:8:41
/infrastructure/server/title.any.sharedworker.html
  FAIL foobar - ReferenceError: Can't find variable: SharedWorker
global code@http://web-platform.test:8000/infrastructure/server/title.any.sharedworker.html:8:41
/infrastructure/testdriver/bless.html
  FAIL user activation - promise_test: Unhandled rejection with value: object "NotSupportedError: The operation is not supported."
promiseReactionJob@[native code]
@gsnedders
Copy link
Member Author

Do we want to workaround these bugs, because they aren't per-se Safari running tests incorrectly? Except maybe the bless.html one?

@foolip
Copy link
Member

foolip commented Oct 5, 2018

@cdumez @youennf could either of you help triage https://bugs.webkit.org/show_bug.cgi?id=187052?

@youennf
Copy link
Contributor

youennf commented Oct 5, 2018

I cced some folks on bugs.webkit.org.
What is the impact of failing these infra tests?

@foolip
Copy link
Member

foolip commented Oct 5, 2018

@youennf it's not a big problem, but in order to run infrastructure/ tests in CI (foolip#5) to ensure that Safari doesn't regress, we'll need to check in expectations about every failure in infrastructure/. That in turn is in service of #13299, i.e., preventing regressions of non-infrastructure tests in Safari before they happen.

Understanding why the tests are failing would be great even if it's not fixed soon.

@foolip
Copy link
Member

foolip commented Oct 5, 2018

For bless.html, this is the failing test:

promise_test(() => {
  const video = document.createElement('video');
  video.setAttribute('src', '/media/counting.ogv');
  document.body.appendChild(video);
  return test_driver.bless('start video playback', () => video.play())
}, 'user activation');

And the failure is Unhandled rejection with value: object "NotSupportedError: The operation is not supported." That's because of /media/counting.ogv, Safari doesn't support Ogg Theora, so #9354.

Switching to /media/counting.mp4 seems to fix the problem.

However, with the same fix, I've also seen flaky timeout or failure due to Unhandled rejection with value: object "AbortError: The operation was aborted." without any extra changes.

Running the tests flips back and forth a lot between the two tabs, which is #10398. My best guess is that media playback is being paused or prevented to start in background tabs.

Anyway, this test doesn't need a media resource as well. Browsers that don't allow media playback without a user gesture will leave video.paused as true, so I'll try to change the test.

foolip added a commit that referenced this issue Oct 5, 2018
See diagnosis of Safari Technology Preview failure:
#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
@foolip
Copy link
Member

foolip commented Oct 5, 2018

I've sent #13403 to fix bless.html.

jugglinmike pushed a commit that referenced this issue Oct 6, 2018
See diagnosis of Safari Technology Preview failure:
#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
@gsnedders
Copy link
Member Author

@youennf probably nothing; https://bugs.webkit.org/show_bug.cgi?id=187052 is the most annoying given it makes it hard to verify behaviour is correct.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 12, 2018
…ver.bless` test, a=testonly

Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403)

See diagnosis of Safari Technology Preview failure:
web-platform-tests/wpt#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
--

wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f
wpt-pr: 13403
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this issue Oct 15, 2018
…ver.bless` test, a=testonly

Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403)

See diagnosis of Safari Technology Preview failure:
web-platform-tests/wpt#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
--

wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f
wpt-pr: 13403
@foolip
Copy link
Member

foolip commented Oct 20, 2018

The test infrastructure/assumptions/allowed-to-play.html test I added in #13622 is also failing in Safari Technology Preview 67.

@foolip
Copy link
Member

foolip commented Oct 20, 2018

I've filed https://bugs.webkit.org/show_bug.cgi?id=190775 for that.

@foolip
Copy link
Member

foolip commented Dec 25, 2018

Downgrading the priority, this isn't causing any widespread trouble it seems.

gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…ver.bless` test, a=testonly

Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403)

See diagnosis of Safari Technology Preview failure:
web-platform-tests/wpt#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
--

wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f
wpt-pr: 13403

UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…ver.bless` test, a=testonly

Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403)

See diagnosis of Safari Technology Preview failure:
web-platform-tests/wpt#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
--

wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f
wpt-pr: 13403

UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…ver.bless` test, a=testonly

Automatic update from web-platform-testsMinimize <video> dependency in `test_driver.bless` test (#13403)

See diagnosis of Safari Technology Preview failure:
web-platform-tests/wpt#12621 (comment)

This test does not need to load any media resource or consider the state
of the returned promise.
--

wpt-commits: 21c33fe4cc3963faa4b38ab19e47660fa72c122f
wpt-pr: 13403

UltraBlame original commit: 113102643432c772f228e02246a2f7d606abe725
@gsnedders
Copy link
Member Author

gsnedders commented Mar 16, 2021

So current issues:

With that being the status now, I don't know if it makes sense to keep the meta issue open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants