Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12975 should have failed CI with NON-EXISTENT-REF #13003

Open
Ms2ger opened this issue Sep 14, 2018 · 4 comments
Open

#12975 should have failed CI with NON-EXISTENT-REF #13003

Ms2ger opened this issue Sep 14, 2018 · 4 comments
Labels
infra lint priority:backlog

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 14, 2018 

$ ./wpt lint css/css-contain
ERROR:lint:css/css-contain/contain-layout-008.html: Reference test with a non-existent 'match' relationship reference: 'reference/contain-paint-013-ref.html' (NON-EXISTENT-REF)

but the only-check-changed-files approach failed to notice this error running on #12975.

CC @jgraham @gsnedders
@jdm jdm mentioned this issue Sep 14, 2018
Closed
@TimothyGu
Copy link
Member

Fixed the issue-on-master for now by merging #12999.

@foolip foolip mentioned this issue Sep 16, 2018
Merged
@gsnedders
Copy link
Member

This is fundamentally the same as #9171, right? Or is this different given it's a lint for a single file that has an undeclared dependency (so we can't invalidate our "cache")?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Sep 19, 2018

Similar, certainly. Sadly special-casing changed in css/ doesn't help here.

@gsnedders
Copy link
Member

I'm not really sure how to fix this except as part of #11388 and doing proper caching and proper dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra lint priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ms2ger @gsnedders @foolip @TimothyGu