DOMWindowTimers::setTimeout and setInterval modified to accept Trusted Types. #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 17, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179899
branch
from
26f1ed9 to
2e1ae16
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179899
branch
from
2e1ae16 to
07e4937
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179899
branch
3 times, most recently
from
e2acb8d to
7acc45c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1179899
branch
from
7acc45c to
80710a8
Compare
|
This Chromium export is blocked because of a failing lint: Seems related to #13003, i.e. a pre-existing failure on master. The problem has been fixed on master (I think) so I'll just rebase this branch. |
Types. New implementations of DOMWindowTimers::setTimeout() and setInterval() added to accept TrustedScript as an argument. Previously existing implementations renamed to setTimeoutFromString() and setIntervalFromString(), respectively. Bug: 739170 Change-Id: I3513ebb651534f0b1ef1b8de9c694136b02e2412 Reviewed-on: https://chromium-review.googlesource.com/1179899 Reviewed-by: Mike West <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Maja Kabus <[email protected]> Cr-Commit-Position: refs/heads/master@{#591327}
foolip
force-pushed
the
chromium-export-cl-1179899
branch
from
80710a8 to
55cc46e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementations of DOMWindowTimers::setTimeout() and setInterval()
added to accept TrustedScript as an argument.
Previously existing implementations renamed to setTimeoutFromString()
and setIntervalFromString(), respectively.
Bug: 739170
Change-Id: I3513ebb651534f0b1ef1b8de9c694136b02e2412
Reviewed-on: https://chromium-review.googlesource.com/1179899
Reviewed-by: Mike West [email protected]
Reviewed-by: Yuki Shiino [email protected]
Commit-Queue: Maja Kabus [email protected]
Cr-Commit-Position: refs/heads/master@{#591327}