Subtract scrollbar in PerpendicularContainingBlockLogicalHeight #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 25, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1028012
branch
from
b30e0e0 to
e078ee1
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1028012
branch
from
e078ee1 to
b01d041
Compare
|
@foolip this is a lint failure as well |
This is an issue that happens in Flexbox and Grid Layout and any other layout method that uses OverrideLogicalHeight. In LayoutBox::PerpendicularContainingBlockLogicalHeight() we were returning the OverrideContentLogicalHeight() plus the scrollbar height. That caused issue with orthogonal flows between flex/grid items and their children. The issue is fixed just following the suggestion in the TODO and using OverrideContentLogicalHeight() (which doesn't include the scrollbar height). BUG=836827 TEST=external/wpt/css/css-flexbox/percentage-size-subitems-001.html TEST=external/wpt/css/css-grid/grid-items/percentage-size-subitems-001.html Change-Id: I0c7586449067aab78430defc831b2774136e2f0b Reviewed-on: https://chromium-review.googlesource.com/1028012 Commit-Queue: Manuel Rego Casasnovas <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Reviewed-by: Javier Fernandez <[email protected]> Cr-Commit-Position: refs/heads/master@{#553790}
css/build-css-testsuites.sh succeeds, so this is probably a false positive.
foolip
force-pushed
the
chromium-export-cl-1028012
branch
from
b01d041 to
42b69a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue that happens in Flexbox and Grid Layout
and any other layout method that uses OverrideLogicalHeight.
In LayoutBox::PerpendicularContainingBlockLogicalHeight()
we were returning the OverrideContentLogicalHeight() plus
the scrollbar height.
That caused issue with orthogonal flows between flex/grid items
and their children.
The issue is fixed just following the suggestion in the TODO
and using OverrideContentLogicalHeight()
(which doesn't include the scrollbar height).
BUG=836827
TEST=external/wpt/css/css-flexbox/percentage-size-subitems-001.html
TEST=external/wpt/css/css-grid/grid-items/percentage-size-subitems-001.html
Change-Id: I0c7586449067aab78430defc831b2774136e2f0b
Reviewed-on: https://chromium-review.googlesource.com/1028012
Commit-Queue: Manuel Rego Casasnovas [email protected]
Reviewed-by: Morten Stenshorne [email protected]
Reviewed-by: Christian Biesinger [email protected]
Reviewed-by: Javier Fernandez [email protected]
Cr-Commit-Position: refs/heads/master@{#553790}