HTML: document.open() and quirks mode #10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
w3c-test:mirror |
This was referenced Jul 12, 2018
TimothyGu
force-pushed
the
annevk/document-open-quirks
branch
from
575bc64 to
928ef30
Compare
wpt-pr-bot
requested review from
domenic,
foolip,
sideshowbarker and
zcorpan
and removed request for
ayg
zcorpan
approved these changes
Jul 20, 2018
foolip
approved these changes
Aug 3, 2018
| assert_equals(frame.contentDocument.compatMode, "CSS1Compat"); | ||
| }, "document.open() and quirks mode (iframe, new doctype)"); | ||
|
|
||
| // Test derived from quirks/blocks-ignore-line-height.html. |
There was a problem hiding this comment.
There's enough here to figure out that the test isn't really about the layout size of those divs, but can you spell out that this is all because there's no way to directly test if one is in limited quirks mode, and that this test is only valid on the assumption that the one linked here passes?
TimothyGu
added a commit
to TimothyGu/html
that referenced
this pull request
Aug 27, 2018
Per investigation in whatwg#3818, this change aligns the behavior of document.open() with Chrome and Safari. Tests: web-platform-tests/wpt#10679
domenic
approved these changes
Aug 27, 2018
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Aug 28, 2018
Per investigation in #3818, this change aligns the behavior of document.open() with Chrome and Safari. Tests: web-platform-tests/wpt#10679. Closes #3831.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
Per investigation in whatwg#3818, this change aligns the behavior of document.open() with Chrome and Safari. Tests: web-platform-tests/wpt#10679. Closes whatwg#3831.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
Per investigation in whatwg#3818, this change aligns the behavior of document.open() with Chrome and Safari. Tests: web-platform-tests/wpt#10679. Closes whatwg#3831.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.