Remove .gitkeep files in 2dcontext/ and html/ #11851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added in commit 818bcab and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456.
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
fserb,
kdashg,
jdm,
jgraham,
kenrussell and
zqzhang
|
Reviewers, if any of you have found these directories useful, please say something. They've mostly annoyed me, and trying to vet which ones are still correct seems like a lot of work. |
domenic
approved these changes
Jul 9, 2018
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 17, 2018
Matches web-platform-tests/wpt#11851. These changes haven't been imported because dot files aren't removed by the importer, which is a bug. Bug: 780538 Change-Id: I3d51d4af5125ec284319ee52074f40f80c83bc47 Reviewed-on: https://chromium-review.googlesource.com/1226141 Commit-Queue: Philip Jägenstedt <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/master@{#591621}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 4, 2019
These are the final remaining .gitkeep files in WPT, after the ones in 2dcontext/ and html/ were removed: web-platform-tests/wpt#11851 Directories in wpt/webaudio/ that disappear as a consequence: the-audio-api/the-audiodestinationnode-interface the-audio-api/the-audiolistener-interface the-audio-api/the-audioprocessingevent-interface the-audio-api/the-mediastreamaudiodestinationnode-interface the-audio-api/the-mediastreamaudiosourcenode-interface the-audio-api/the-periodicwave-interface the-audio-api/the-scriptprocessornode-interface Change-Id: I422a459d58c4739b8b34cbf54d2aea5c721a7da8 Reviewed-on: https://chromium-review.googlesource.com/c/1244839 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Hongchan Choi <[email protected]> Reviewed-by: Robert Ma <[email protected]> Cr-Commit-Position: refs/heads/master@{#628738}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added in commit 818bcab
and reflect the structure of the HTML spec as it was in 2012.
The structure largely remains the same, but some directories like
webappapis/user-prompts/dialogs-implemented-using-separate-documents/
are gone from the spec (whatwg/html#374) and
others like introduction/ are non-normative and should never be
populated.
But mainly, a lot of empty directories is a nuisance when exploring
the directory in a file manager or on GitHub.
The number of directories in 2dcontext/ and html/ combined decreases
by almost 200, from 653 to 456.