HTML: document.open() and event listener removal #12122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
sideshowbarker,
zcorpan and
zqzhang
TimothyGu
requested review from
jdm,
sideshowbarker,
zcorpan,
jgraham and
zqzhang
and removed request for
jdm,
sideshowbarker,
zcorpan,
jgraham and
zqzhang
19 tasks
foolip
approved these changes
Jul 24, 2018
TimothyGu
added a commit
to TimothyGu/html
that referenced
this pull request
Aug 8, 2018
TimothyGu
force-pushed
the
timothygu/document-open-events
branch
from
532ba9d to
2279097
Compare
annevk
approved these changes
Aug 9, 2018
|
This is probably best squashed and merged. Please also reference whatwg/html#3893 in the commit. |
|
Yeah I'll squash the last three commits together. |
TimothyGu
force-pushed
the
timothygu/document-open-events
branch
from
2279097 to
050853f
Compare
TimothyGu
force-pushed
the
timothygu/document-open-events
branch
from
050853f to
a595475
Compare
TimothyGu
added a commit
to TimothyGu/html
that referenced
this pull request
Aug 9, 2018
This change aligns the event listener removal behavior with implementations, specifically in two aspects: - The event handler's value should be set to null (i.e., deactivated). - Event listeners and handlers should be removed from the Window object as well. See prior investigation around deactivation of event handlers in whatwg#3836 and whatwg#3850. See investigation around `document.open()`'s behavior in whatwg#3818. Tests: web-platform-tests/wpt#12122
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Aug 9, 2018
This change aligns the event listener removal behavior with implementations, specifically in two aspects: - The event handler's value should be set to null (i.e., deactivated). - Event listeners and handlers should be removed from the Window object as well. See prior investigation around deactivation of event handlers in #3836 and #3850. See investigation around document.open()'s behavior in #3818. Tests: web-platform-tests/wpt#12122
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This change aligns the event listener removal behavior with implementations, specifically in two aspects: - The event handler's value should be set to null (i.e., deactivated). - Event listeners and handlers should be removed from the Window object as well. See prior investigation around deactivation of event handlers in whatwg#3836 and whatwg#3850. See investigation around document.open()'s behavior in whatwg#3818. Tests: web-platform-tests/wpt#12122
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This change aligns the event listener removal behavior with implementations, specifically in two aspects: - The event handler's value should be set to null (i.e., deactivated). - Event listeners and handlers should be removed from the Window object as well. See prior investigation around deactivation of event handlers in whatwg#3836 and whatwg#3850. See investigation around document.open()'s behavior in whatwg#3818. Tests: web-platform-tests/wpt#12122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.