Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default name ("idl_test setup") for idl_test #12276

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 2, 2018

The name given is never very meaningful. Remove the name in one test
to show it working.

The name given is never very meaningful. Remove the name in one test
to show it working.
@lukebjerring
Copy link
Contributor

Seems reasonable and avoids inconsistently leaving the naming to the author (e.g. Test driver, [foo] interfaces, etc)

@lukebjerring lukebjerring merged commit 70413d8 into master Aug 2, 2018
@lukebjerring lukebjerring deleted the idl_test_setup branch August 2, 2018 13:18
foolip added a commit that referenced this pull request Aug 10, 2018
foolip added a commit that referenced this pull request Aug 13, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 15, 2018
…always 'idl_test setup'), a=testonly

Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406)

Completes what web-platform-tests/wpt#12276 started.
--

wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4
wpt-pr: 12406
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 15, 2018
…always 'idl_test setup'), a=testonly

Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406)

Completes what web-platform-tests/wpt#12276 started.
--

wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4
wpt-pr: 12406
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…always 'idl_test setup'), a=testonly

Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406)

Completes what web-platform-tests/wpt#12276 started.
--

wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4
wpt-pr: 12406

UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…always 'idl_test setup'), a=testonly

Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406)

Completes what web-platform-tests/wpt#12276 started.
--

wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4
wpt-pr: 12406

UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…always 'idl_test setup'), a=testonly

Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406)

Completes what web-platform-tests/wpt#12276 started.
--

wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4
wpt-pr: 12406

UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants