-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a default name ("idl_test setup") for idl_test #12276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name given is never very meaningful. Remove the name in one test to show it working.
lukebjerring
approved these changes
Aug 2, 2018
Seems reasonable and avoids inconsistently leaving the naming to the author (e.g. |
foolip
added a commit
that referenced
this pull request
Aug 13, 2018
) Completes what #12276 started.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 15, 2018
…always 'idl_test setup'), a=testonly Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406) Completes what web-platform-tests/wpt#12276 started. -- wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4 wpt-pr: 12406
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Aug 15, 2018
…always 'idl_test setup'), a=testonly Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406) Completes what web-platform-tests/wpt#12276 started. -- wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4 wpt-pr: 12406
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…always 'idl_test setup'), a=testonly Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406) Completes what web-platform-tests/wpt#12276 started. -- wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4 wpt-pr: 12406 UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…always 'idl_test setup'), a=testonly Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406) Completes what web-platform-tests/wpt#12276 started. -- wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4 wpt-pr: 12406 UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…always 'idl_test setup'), a=testonly Automatic update from web-platform-testsRemove the idl_test test_name argument (always 'idl_test setup') (#12406) Completes what web-platform-tests/wpt#12276 started. -- wpt-commits: a570eb13b74de9de57230c95e3a302699ce0e7c4 wpt-pr: 12406 UltraBlame original commit: dfc43ee60dce242e7a1a1c467cfc0601cbf778e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name given is never very meaningful. Remove the name in one test
to show it working.