Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Add checks for the return value of document.open() #12359

Merged
merged 1 commit into from
Aug 9, 2018
Merged

HTML: Add checks for the return value of document.open() #12359

merged 1 commit into from
Aug 9, 2018

Conversation

TimothyGu
Copy link
Member

Edge currently fails some of these as they return null instead of the document sometimes.

@TimothyGu TimothyGu mentioned this pull request Aug 8, 2018
Closed
19 tasks
@wpt-pr-bot wpt-pr-bot added the html label Aug 8, 2018
annevk
annevk approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Please file an issue against Edge.

@TimothyGu
Copy link
Member Author

@annevk Edge is already aware of this problem but will do!

@TimothyGu TimothyGu merged commit ea85edd into master Aug 9, 2018
@TimothyGu TimothyGu deleted the timothygu/document-open-bailouts branch August 9, 2018 15:41
@TimothyGu
Copy link
Member Author

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18605326/

@TimothyGu TimothyGu self-assigned this Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@TimothyGu TimothyGu

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyGu @annevk @wpt-pr-bot