Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ignore-opens-during-unload counter in Document #12413

Merged
merged 1 commit into from
Aug 16, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,15 +1,60 @@
for (const ev of ["unload", "beforeunload", "pagehide"]) {
for (const [ev, target] of [
["beforeunload", iframe => iframe.contentWindow],
["pagehide", iframe => iframe.contentWindow],
["unload", iframe => iframe.contentWindow],
["visibilitychange", iframe => iframe.contentDocument],
]) {
async_test(t => {
const iframe = document.body.appendChild(document.createElement("iframe"));
t.add_cleanup(() => iframe.remove());
iframe.src = "/common/blank.html";
iframe.onload = t.step_func(() => {
iframe.contentWindow.addEventListener(ev, t.step_func_done(() => {
target(iframe).addEventListener(ev, t.step_func_done(() => {
assert_not_equals(iframe.contentDocument.childNodes.length, 0);
assert_equals(iframe.contentDocument.open(), iframe.contentDocument);
assert_not_equals(iframe.contentDocument.childNodes.length, 0);
}));
iframe.src = "about:blank";
});
}, `document.open should bail out when ignore-opens-during-unload is greater than 0 during ${ev} event`);
}, `document.open should bail out when ignore-opens-during-unload is greater than 0 during ${ev} event (in top-level browsing context)`);

async_test(t => {
const iframe = document.body.appendChild(document.createElement("iframe"));
t.add_cleanup(() => iframe.remove());
iframe.src = "/common/blank.html?1";
iframe.onload = t.step_func(() => {
const doc = iframe.contentDocument;
const innerIframe = doc.body.appendChild(doc.createElement("iframe"));
innerIframe.src = "/common/blank.html?2";
innerIframe.onload = t.step_func(() => {
// Navigate the parent, listen on the child, and open() the parent.
target(innerIframe).addEventListener(ev, t.step_func_done(() => {
assert_not_equals(iframe.contentDocument.childNodes.length, 0);
iframe.contentDocument.open();
assert_not_equals(iframe.contentDocument.childNodes.length, 0);
}));
iframe.src = "about:blank";
});
});
}, `document.open should bail out when ignore-opens-during-unload is greater than 0 during ${ev} event (open(parent) while unloading parent and child)`);

async_test(t => {
const iframe = document.body.appendChild(document.createElement("iframe"));
t.add_cleanup(() => iframe.remove());
iframe.src = "/common/blank.html?1";
iframe.onload = t.step_func(() => {
const doc = iframe.contentDocument;
const innerIframe = doc.body.appendChild(doc.createElement("iframe"));
innerIframe.src = "/common/blank.html?2";
innerIframe.onload = t.step_func(() => {
// Navigate the child, listen on the child, and open() the parent.
target(innerIframe).addEventListener(ev, t.step_func_done(() => {
assert_not_equals(iframe.contentDocument.childNodes.length, 0);
iframe.contentDocument.open();
assert_equals(iframe.contentDocument.childNodes.length, 0);
}));
innerIframe.src = "about:blank";
});
});
}, `document.open should bail out when ignore-opens-during-unload is greater than 0 during ${ev} event (open(parent) while unloading child only)`);
}