Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idlharness test for font-metrics-api #12950

Conversation

lukebjerring
Copy link
Contributor

Required a manual tweak to the IDL (sequences aren't valid in attributes).

@eaenet - is it worth having this test coverage for the IDL in WPT?

@foolip
Copy link
Member

foolip commented Oct 7, 2019

The IDL file was added in #12914, but since https://wpt.fyi/results/fonts/metrics/idlharness.window.html?label=pr_head&max-count=1&pr=12950 shows nothing passing in any browser it's probably best to delete the IDL file and leave it as an open autofoolip PR like #12805.

foolip added a commit that referenced this pull request Oct 7, 2019
@foolip
Copy link
Member

foolip commented Oct 7, 2019

Sent #19544. When that's landed and autofoolip creates a PR to add it back, I'll link to this PR as something to revive if implementer interest materializes.

lukebjerring pushed a commit that referenced this pull request Oct 7, 2019
@foolip
Copy link
Member

foolip commented Oct 7, 2019

Closing now, #19545 links to this for future revival.

@foolip foolip closed this Oct 7, 2019
@foolip foolip deleted the idl-file-updates-font-metrics-api branch October 7, 2019 12:31
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 17, 2019
Automatic update from web-platform-tests
Delete font-metrics-api.idl (#19544)

It is unused, see web-platform-tests/wpt#12950 (comment).
--

wpt-commits: 238225a1d4ba5869b443f113245aa9d2e9b1110e
wpt-pr: 19544
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 18, 2019
Automatic update from web-platform-tests
Delete font-metrics-api.idl (#19544)

It is unused, see web-platform-tests/wpt#12950 (comment).
--

wpt-commits: 238225a1d4ba5869b443f113245aa9d2e9b1110e
wpt-pr: 19544
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 19, 2019
Automatic update from web-platform-tests
Delete font-metrics-api.idl (#19544)

It is unused, see web-platform-tests/wpt#12950 (comment).
--

wpt-commits: 238225a1d4ba5869b443f113245aa9d2e9b1110e
wpt-pr: 19544

UltraBlame original commit: 07340555601259a8b8777f3fed244aba65f7d7a3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 19, 2019
Automatic update from web-platform-tests
Delete font-metrics-api.idl (#19544)

It is unused, see web-platform-tests/wpt#12950 (comment).
--

wpt-commits: 238225a1d4ba5869b443f113245aa9d2e9b1110e
wpt-pr: 19544

UltraBlame original commit: 07340555601259a8b8777f3fed244aba65f7d7a3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 19, 2019
Automatic update from web-platform-tests
Delete font-metrics-api.idl (#19544)

It is unused, see web-platform-tests/wpt#12950 (comment).
--

wpt-commits: 238225a1d4ba5869b443f113245aa9d2e9b1110e
wpt-pr: 19544

UltraBlame original commit: 07340555601259a8b8777f3fed244aba65f7d7a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants