Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urange Parsing #15195

Merged
merged 6 commits into from
Feb 1, 2019
Merged

Urange Parsing #15195

merged 6 commits into from
Feb 1, 2019

Conversation

tabatkins
Copy link
Contributor

Fairly exhaustively test parsing, and make sure UAs aren't cheating with specialized tokens.

Fairly exhaustively test <urange> parsing, and make sure UAs aren't cheating with specialized tokens.
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that tests for should-be-valid syntax start from a stable value as well, so they don't depend on test ordering so much.
Was pretty sure selectors serialized with spaces around the combinator, but wasn't sure, and Chrome failed the test anyway. Firefox passes but with spaces, so make sure I match that.
Urange serialization isn't specified, so I shouldn't rely on the casing in this test, at least. Instead, just uppercase things, since casing doesn't matter.
@tabatkins tabatkins merged commit 62bfaeb into master Feb 1, 2019
@tabatkins tabatkins deleted the tabatkins-patch-1 branch February 1, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants