Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTCDataChannel-binaryType.html from PR13499 #16043

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add RTCDataChannel-binaryType.html from PR13499 #16043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
927a623
Add tests from RTCDataChannel-binaryType.html, initial version taken …
youennf Mar 24, 2019
14a0a4e
Remove initial value test of binaryType
dontcallmedom Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions webrtc/RTCDataChannel-binaryType.window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

const validBinaryTypes = ['blob', 'arraybuffer'];
const invalidBinaryTypes = ['jellyfish', 'arraybuffer ', '', null, undefined];

for (const binaryType of validBinaryTypes) {
test((t) => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
const dc = pc.createDataChannel('test-binary-type');

dc.binaryType = binaryType;
assert_equals(dc.binaryType, binaryType, `dc.binaryType should be '${binaryType}'`);
}, `Setting binaryType to '${binaryType}' should succeed`);
}

for (const binaryType of invalidBinaryTypes) {
test((t) => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
const dc = pc.createDataChannel('test-binary-type');

assert_throws('SyntaxError', () => {
dc.binaryType = binaryType;
});
}, `Setting invalid binaryType '${binaryType}' should throw SyntaxError`);
}